Buying and selling of foreign currencies is legal and halaal in Islam, as long as the trading and exchange is done on spot payment and exchanged. Please note here that ‘margin-trading’ or any of its derivatives are not allowed in Islam.
Buying and selling of gold and silver or any other commodity is legal and halaal in Islam, as long as the trading and exchange is done on spot payment and exchanged. Here again ‘margin-trading’ or any of its derivatives are not allowed in Islam.